Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lib): add additive behavior #94

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(lib): add additive behavior #94

wants to merge 3 commits into from

Conversation

vascocc
Copy link

@vascocc vascocc commented Dec 1, 2019

This commit adds additive behavior, mimicking the behavior when holding the Shift key.
Updated app to be able to select addictive behavior.
Updated Cypress tests.
Updated documentation.

@vascocc
feat(lib): add additive behavior
8816035 
This commit adds additive behavior, mimicking the behavior when holding the Shift key.
Updated app to be able to select addictive behavior.
Updated Cypress tests.
Updated documentation.
@vascocc
feat(lib): add additive behavior
d19e31f 
This commit adds additive behavior, mimicking the behavior when holding the Shift key.
Fixed Additive implementation;
Updated tests and documentation;
@vascocc vascocc mentioned this pull request Dec 1, 2019
Closed
@vascocc
Copy link
Author

vascocc commented Dec 1, 2019 •
edited by d3lm
Loading

@d3lm, I couldn't implement the unselect items when dragging through them, they started flickering.
Can you have a look and point me in the right direction?

Cheers

@d3lm
Copy link
Owner

d3lm commented Oct 27, 2020

Hey @vascocc, sorry for the late response, but do you still want to work on this PR? I am doing a bit of maintenance and closing stale PR's / issues. I still think this feature is cool, so maybe we can get it over the finish line?

@d3lm d3lm force-pushed the master branch 17 times, most recently from 93f1299 to 1afd221 Compare October 28, 2020 23:49
@s-f-a-g
Copy link

s-f-a-g commented Nov 30, 2020

Hi guys, any idea of when this feature will be merged ? Is takes a very long time for conflict on README file...
Cheers guys, hope you are all well

@d3lm
Copy link
Owner

d3lm commented Dec 1, 2020 •
edited
Loading

@s-f-a-g FWIW, it's not just the readme. Check our PR conversation. With the current state of this PR it's not compatible with all existing features and unselecting doesn't work.

@d3lm d3lm force-pushed the master branch 3 times, most recently from f737d7d to 1fd7215 Compare December 5, 2021 18:20
@Eagleseb
Copy link
Contributor

hey
we need this feature in our project. So much so that I tried implementing it myself before discovering that PR.
I have tested it, it works really well except that selected elements are not put into "tmp" when dragging. And so they're not removed if you then unselect them while dragging.

Is there anything I could do to help and merge this feature?

@d3lm
Copy link
Owner

d3lm commented Nov 21, 2022

This PR is quite out of date already. If you want @Eagleseb, you could take over this PR, in case @vascocc is not working on this anymore, and implement the missing pieces. What do you think?

@vascocc
Copy link
Author

vascocc commented Nov 21, 2022

Not working on this anymore.

@Eagleseb
Copy link
Contributor

yes I'd be happy to help if you could point me the missing pieces
as I said it's working well on our side except for the "temporary selection" while dragging which is actually not temporary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vascocc @d3lm @s-f-a-g @Eagleseb