Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lib): add input for intersection mode #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PhOder
Copy link

@PhOder PhOder commented Nov 29, 2022

This commit adds a new @Input() property intersectionMode to the SelectContainerComponent that allows to modify if items' bounding boxes need to be fully included in the select box or (by default) if bounding boxes need to intersect.

@PhOder
Copy link
Author

PhOder commented Nov 29, 2022

Hi @d3lm =)
In this PR I'd like to suggest a new input property as described above.

I'm unsure about the naming with the available options for this:
@Input() intersectionMode: 'intersection' | 'included' = 'intersection';

This commit adds a new `@Input()` property `intersectionMode` to the
`SelectContainerComponent` that allows to modify if items' bounding
boxes need to be fully included in the select box or (by default) if
bounding boxes need to intersect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants