-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update 29 formula #597
base: master
Are you sure you want to change the base?
update 29 formula #597
Conversation
@d12frosted I am able to install this with
I was not getting this error when installing in this way on aff45bb |
dffa970
to
d17700a
Compare
Never tested the 'local_patch' helper with custom path for tap. Try tapping without custom path :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 thank you very much! that's exactly what needs to be done
if possible, extract aot as a separate PR 🙏 would love to keep commits clean
for you it will be extra contribution ;)
|
||
url "https://github.com/emacs-mirror/emacs.git", :branch => "emacs-29" | ||
|
||
if build.with? "native-comp" and build.with? "native-comp-aot" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally I would love to introduce extra option separately from 29.1 release
p.s. what is the difference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I split the commit to 2 commits. Do you still want a separate PR for the ahead-of-time commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the difference?
all core elisp gets compiled immediately instead of just-in-time during usage.
Users can now choose between --with-native-comp or --with-native-comp-aot which will set the --with-native-comp compile flag to `yes` or `aot` respectively.
d17700a
to
bab0a71
Compare
This was because i was tapping (arbitrarily) to Once I resolved that I'm able to tap locally and install successfully. |
Thank you! I cherry picked your first two commits. Please open a separate PR for AOT. And don't forget to add this option to documentation 🙏 |
Addressing @d12frosted comments in #593 to update 29 target and documentation.
Also includes ahead-of-time native compilation flag. I added this as a separate flag from regular native compilation — lmk if you'd prefer a different approach.
Closes #595