Implement a compliant ERC20 without a name / symbol / decimal functions #27
Conversation
src/ERC20NoViews.sol
Outdated
| string private constant name = "Token"; | ||
| string private constant symbol = "TKN"; | ||
| uint8 private decimals = 18; |
There was a problem hiding this comment.
Seems like this could be removed as it's not used anywhere in the contract nor has any possibility to be read from another contract
There was a problem hiding this comment.
I think this still can be presented in the contract because the absence of name / symbol / decimal functions may be due to the developer of the contract forgetting to implement them for private variables.
| @@ -0,0 +1,66 @@ | |||
| // Copyright (C) 2017, 2018, 2019, 2020, 2024 dbrock, rain, mrchico, d-xo, sqrlfirst | |||
There was a problem hiding this comment.
hey @sqrlfirst I believe that copyright should always go to the owner of the repository!
There was a problem hiding this comment.
Nop, it shall go depending on the CONTRIBUTING.md (which is absent from this repository) and who's doing the code writing... you know the author :)
There was a problem hiding this comment.
hey @Magicking well! I leave it up to the repository owner :)
| event Transfer(address indexed src, address indexed dst, uint wad); | ||
|
|
||
| // --- Init --- | ||
| constructor(uint _totalSupply) public { |
There was a problem hiding this comment.
remove public visibility in the constructor!
There was a problem hiding this comment.
Thanks @luislucena16 but if you look line 4, (3 below the copyright), it mentions Solidity 0.6.12 which according to the documentation still mention « public »
See https://docs.soliditylang.org/en/v0.6.12/style-guide.html?#order-of-functions
There was a problem hiding this comment.
yes, of course, but will the old version still be used even for the new features?..
There was a problem hiding this comment.
It's accurate for the solidity compiler version specified, not sure what your words means.
Add an ERC20 without
name,symbol,decimalsas described in issue #22 from @Magicking