-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support falcon datasets with latest micromanager #237
Conversation
Does it make sense to remove the naming convention and replace with the new? Can we just add a new |
We are trying to keep this code clean, so I'd prefer fixing this issue properly rather than adding switch cases. I'll make time to test this, help from @ziw-liu or @talonchandler confirming that |
Tested and ready to merge after review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Thanks!
This PR adds support for
Tested on:
Input:
/hpc/instruments/cm.falcon/zebrafish/20240808_coro1a_mpeg_1dpf_10x/fish_with_coro1a_1/
Output:
/hpc/projects/balla_group/imaging/zebrafish_infection/falcon/2024_08_08_coro1a_mpeg_1dpf_10x/0-zarr/timelapse1.zarr
@ieivanov the new Tile Creator prefix format might affect OPS in this future, so I'm requesting your review.
@dsundarraman heads up that we need to convert with this branch going forward.
TODO:
xy_stage = pos.get("DefaultXYStage"); stage_pos = pos.get(xy_stage)
handles all previous cases