Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Replacing LayerCI references with webapp.io (finishing previous PR) #28874

Merged
merged 6 commits into from
Feb 19, 2024

Conversation

joshuadsouza
Copy link
Contributor

  • Closes

Additional details

LayerCI has rebranded to webapp.io, context here https://webapp.io/blog/layerci-has-rebranded-to-webapp-io/.

The environment build variables have updated in webapp.io to some new variables (instead of the old ones with reference to LayerCI). Refer to the following documentation in webapp.io with the environment build variables

This PR finishes up the work done in this previously opened PR https://github.com/cypress-io/cypress/pull/28577/files and also adds in the EXPOSE_WEBSITE_HOST build environment variable exposed by webapp.io

Steps to test

How has the user experience changed?

PR Tasks

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2024

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshuadsouza What's the intention behind adding the EXPOSE_WEBSITE_HOST? I don't think this env var is needed. These env vars are primarily surfaced for Cypress use, and we don't have a need for this env var that I can see.

Otherwise this looks good!

@joshuadsouza
Copy link
Contributor Author

@joshuadsouza What's the intention behind adding the EXPOSE_WEBSITE_HOST? I don't think this env var is needed. These env vars are primarily surfaced for Cypress use, and we don't have a need for this env var that I can see.

Otherwise this looks good!

Got it, just updated the PR and removed EXPOSE_WEBSITE_HOST 👍

@jennifer-shehane jennifer-shehane merged commit 2f86203 into cypress-io:develop Feb 19, 2024
67 checks passed
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 20, 2024

Released in 13.6.5.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.5, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants