Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated workshops #5865

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

MikeMcC399
Copy link
Contributor

Issue

The Examples > Workshops page contains 2 outdated workshops:

which are both based on legacy versions of Cypress.

Changes

Copy link

netlify bot commented Jul 4, 2024

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit dd29cb9

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399 MikeMcC399 marked this pull request as ready for review July 4, 2024 06:55
@MikeMcC399
Copy link
Contributor Author

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. There's nothing here. 😅 We can probably just remove this entire page from the docs. Let me know if you need any assistance.

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

We can probably just remove this entire page from the docs.

Done

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. People directed to the workshop URL or the old workshop URL will see a 404 page, but the nav is present there and I think should be fine for someone to find where they want to go. We don't have an exact match for where to redirect them to.

Screenshot 2024-07-09 at 10 54 38 AM

@jennifer-shehane jennifer-shehane merged commit 700bf79 into cypress-io:main Jul 9, 2024
3 checks passed
@MikeMcC399 MikeMcC399 deleted the remove/old-workshops branch July 9, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated workshop entries with legacy Cypress versions
3 participants