Fix compilation on 32bit architectures such as i386, armhf #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On those architectures, the tests fail to build with an overflow error: src/github.com/cyphar/filepath-securejoin/mkdir_linux_test.go:254:8: constant 2147484159 overflows int FAIL github.com/cyphar/filepath-securejoin [build failed] Turns out that FileMode is defined as an uint32 in the os.fs package. Since `MkdirAll` is intended as a replacement for os.MkdirAll, it makes sense to use the same types for all arguments, and that means os.FileMode for the mode parameter. Signed-off-by: Reinhard Tartler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On those architectures, the tests fail to build with an overflow error:
src/github.com/cyphar/filepath-securejoin/mkdir_linux_test.go:254:8: constant 2147484159 overflows int FAIL
github.com/cyphar/filepath-securejoin [build failed]
Turns out that FileMode is defined as an uint32 in the os.fs package. Since
MkdirAllis intended as a replacement for os.MkdirAll, it makes sense to use the same types for all arguments, and that means os.FileMode for the mode parameter.