Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Sonar) Fixed finding: "@Override should be used on overriding and … #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pixeeai
Copy link

@pixeeai pixeeai commented Jun 3, 2024

Remediation

This change fixes "@Override should be used on overriding and implementing methods" (id = java:S1161) identified by Sonar.

Details

This change adds missing @Override to known subclasses. Documenting inheritance will help readers and static analysis tools understand the code better, spot bugs easier, and in general lead to more efficient and effective review.

Our changes look something like this:

  interface AcmeParent {
     void doThing();
  } 

  class AcmeChild implements AcmeParent {

+   @Override
    void doThing() {
      thing();
    }
    
  }
More reading

🧚🤖 Powered by Pixeebot

@pixeeai
Copy link
Author

pixeeai commented Jun 4, 2024

FYI - This change was autogenerated from a GitHub app - called Pixeebot. A code-quality GitHub App; like Dependabot, but for source code. Feel free to check it our for more details for how you can install it onto your project's repo for continued code hardening and code security recommendations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant