Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property to prevent scanning all @Value annotation by default. #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bnasslahsen
Copy link
Contributor

@bnasslahsen bnasslahsen commented Jul 29, 2023

Desired Outcome

The goal of this PR is to prevent default scanning of all @Value annotations by default
This can have huge performance impact on application startup: In real customer context, application slowed from 21s to 170s as of too many invalid secrets retrieval.

With the following code:
image

Developer will get as result:
image

Implemented Changes

This PR introduces new property conjur.scan-all-values that allow the developer to explicitly enable all @Value annotation scanning.
The bean ConjurCloudProcessor will be loaded only if conjur.scan-all-values is set to true and ConjurPropertySource bean is not present.

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant