Add property to prevent scanning all @Value annotation by default. #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
The goal of this PR is to prevent default scanning of all
@Value
annotations by defaultThis can have huge performance impact on application startup: In real customer context, application slowed from 21s to 170s as of too many invalid secrets retrieval.
With the following code:
![image](https://private-user-images.githubusercontent.com/13404829/256984983-a7d5bd98-8399-469a-b867-f9bbcd0cdcf8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU1OTczNzYsIm5iZiI6MTcyNTU5NzA3NiwicGF0aCI6Ii8xMzQwNDgyOS8yNTY5ODQ5ODMtYTdkNWJkOTgtODM5OS00NjlhLWI4NjctZjliYmNkMGNkY2Y4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA2VDA0MzExNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU5MmZmOTI4ZDQ2ZGNiNGM3ZGQ4NTE0YzYyMTliODRmZmQ3NmY4YmM0NDRmYTgwNWE1MmYyZjNmYzc5ZjRhYjUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Z7sgMylxpcB5uWh0roRxSbMwYjFf8RzQ1FXB0aWmwno)
Developer will get as result:
![image](https://private-user-images.githubusercontent.com/13404829/256985015-6cafd2c0-53ff-47b7-971a-b7e66bfbe791.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU1OTczNzYsIm5iZiI6MTcyNTU5NzA3NiwicGF0aCI6Ii8xMzQwNDgyOS8yNTY5ODUwMTUtNmNhZmQyYzAtNTNmZi00N2I3LTk3MWEtYjdlNjZiZmJlNzkxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA2VDA0MzExNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFkZjJjNGY0YWNlZjc3ZTA3ZmY1ZWE0OWYxNGJlZWIxMjkwNGM2OTIzOWQxYjYxOTAyOTk1YTUzMWQwYTBlMmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.3OAhDkm3Bke1oqJtmVYBq7f4u-wEuJlB9ZdzcQ7da4Y)
Implemented Changes
This PR introduces new property
conjur.scan-all-values
that allow the developer to explicitly enable all@Value
annotation scanning.The bean
ConjurCloudProcessor
will be loaded only ifconjur.scan-all-values
is set to true andConjurPropertySource
bean is not present.Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
README
s) were updated in this PRBehavior
Security