Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extra authenticators for auth status test #142

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

telday
Copy link
Contributor

@telday telday commented Feb 12, 2021

What does this PR do?

Adds some basic tests for using the previously non-tested authenticators on the authenticator status endpoint. We didn't want the overhead of standing up cloud authenticators so we ended up writing unit tests for the two alternates.

What ticket does this PR close?

Resolves #99

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

@telday telday requested a review from a team as a code owner February 12, 2021 15:18
Copy link
Contributor

@john-odonnell john-odonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Small suggestion + rebase might do it.

test/python/test_status_api.py Show resolved Hide resolved
Copy link
Contributor

@john-odonnell john-odonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@john-odonnell john-odonnell merged commit a2c03eb into main Feb 22, 2021
@john-odonnell john-odonnell deleted the test-authenticators branch February 22, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Test all authenticators for authenticator status endpoint
2 participants