Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test all authenticators for authenticator status endpoint #99

Closed
telday opened this issue Dec 29, 2020 · 3 comments · Fixed by #142
Closed

Test all authenticators for authenticator status endpoint #99

telday opened this issue Dec 29, 2020 · 3 comments · Fixed by #142

Comments

@telday
Copy link
Contributor

telday commented Dec 29, 2020

Is your feature request related to a problem? Please describe.

Currently the authenticator status endpoint is only tested using the azure and oidc authenticators. We should test against all authenticators which work with this endpoint.

@telday
Copy link
Contributor Author

telday commented Feb 8, 2021

@izgeri The three authenticators which support this endpoint are OIDC, GCP, and Azure. We already test with OIDC, however in order to use GCP and Azure we would need some external setup. Do we actually want to get these two authenticators setup so we can test 200 responses or should we just run the failing tests on all possible authenticators?

@izgeri
Copy link
Contributor

izgeri commented Feb 9, 2021

There are e2e tests running in cyberark/conjur - do those tests cover the 200 responses sufficiently?

Also, is it possible to achieve this with a mock server, sort of like @doodlesbykumbi has done with AWS here: cyberark/secretless-broker#1379

@telday
Copy link
Contributor Author

telday commented Feb 9, 2021

It looks like the Conjur tests have pretty good coverage of both authenticators. I don't think we can directly setup a mock server like in that example, however we can achieve the same functionality with unittest "mock"ing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment