Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the release binary during integration tests #80

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

doodlesbykumbi
Copy link
Contributor

Desired Outcome

The idea here is that integration tests are meant to test the release artefacts. Prior to this change we're compiling some ad-hoc binary (albeit from the same source code as the release binary). This change makes it so that the integration tests are run using the release binary.

Implemented Changes

Describe how the desired outcome above has been achieved with this PR. In
particular, consider:

  • What's changed? Why were these changes made?
  • How should the reviewer approach this PR, especially if manual tests are required?
  • Are there relevant screenshots you can add to the PR description?

Connected Issue/Story

Resolves #[relevant GitHub issue(s), e.g. 76]

CyberArk internal issue ID: [insert issue ID]

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@doodlesbykumbi doodlesbykumbi requested a review from a team as a code owner January 19, 2023 01:48
@doodlesbykumbi doodlesbykumbi changed the base branch from master to release-container-images January 19, 2023 12:26
@codeclimate
Copy link

codeclimate bot commented Jan 19, 2023

Code Climate has analyzed commit 408ddf2 and detected 9 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 2
Bug Risk 7

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 68.0% (0.0% change).

View more on Code Climate.

@szh
Copy link
Contributor

szh commented Jan 19, 2023

@doodlesbykumbi For the OIDC login to work in CI, you'll need to build the binary with the "dev" build tag so the authn_oidc_dev.go file will be included. Otherwise you'll get an error when it tries to open a browser.

@doodlesbykumbi doodlesbykumbi force-pushed the release-container-images branch 4 times, most recently from a30dd25 to 0820604 Compare January 20, 2023 14:29
Base automatically changed from release-container-images to master January 20, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants