Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for Identity #135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

juniortaeza
Copy link
Contributor

@juniortaeza juniortaeza commented May 1, 2023

Desired Outcome

This pull request adds integration tests for Identity.

Implemented Changes

  • adds integration tests for Identity
  • updates start script to support Identity configurations
  • updates container to capture Identity environment variables
  • adds Identity users template file for policy loading and general secrets file

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • [] No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@juniortaeza juniortaeza requested a review from a team as a code owner May 1, 2023 17:09
@@ -169,13 +170,14 @@ func testLogout(t *testing.T, tmpDir string, conjurCLI *conjurCLI, aoc authnOidc
})
}

func RunOIDCIntegrationTests(t *testing.T) {
func TestOIDCIntegration(t *testing.T) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function TestOIDCIntegration has 114 lines of code (exceeds 70 allowed). Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented May 1, 2023

Code Climate has analyzed commit fb5d4e1 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 82.3% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant