-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for buildpack to work on a windows stack #184
Conversation
Can you please signoff on your commits? |
It's looking like we won't be able to get Windows support in our CI environment so quickly, and we don't want that to hold up merging this. We're going to need to arrange for the Windows tests to run locally only, and document how to run them in CONTRIBUTING.md. |
I just rebased on main |
I've squashed the PR into a single commit |
Signed-off-by: Shlomo Heigh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ready to merge!
Desired Outcome
This change is to add windows compatibility for the conjur buildpack.
Implemented Changes
Describe how the desired outcome above has been achieved with this PR. In
particular, consider:
supply.bat
/supply.ps1
windows scripts that ports the functionality of thesupply
bash script0001_retrieve-secrets.bat
windows batch script that ports the functionality of the0001_retrieve-secrets.sh
bash scriptconjur-env
manifest.yml
Connected Issue/Story
Resolves #[182]
CyberArk internal issue ID: [insert issue ID]
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
README
s) were updated in this PRBehavior
Security