Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for buildpack to work on a windows stack #184

Merged
merged 1 commit into from
May 22, 2024

Conversation

dbathgate
Copy link
Contributor

@dbathgate dbathgate commented Apr 16, 2024

Desired Outcome

This change is to add windows compatibility for the conjur buildpack.

Implemented Changes

Describe how the desired outcome above has been achieved with this PR. In
particular, consider:

  • Added supply.bat/supply.ps1 windows scripts that ports the functionality of the supply bash script
  • Added 0001_retrieve-secrets.bat windows batch script that ports the functionality of the 0001_retrieve-secrets.sh bash script
  • Updated build step to compile a windows binary for conjur-env
  • Added necessary buildpack files to manifest.yml

Connected Issue/Story

Resolves #[182]

CyberArk internal issue ID: [insert issue ID]

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@dbathgate dbathgate requested a review from a team as a code owner April 16, 2024 15:38
@szh szh requested a review from doodlesbykumbi April 16, 2024 20:16
@szh
Copy link
Contributor

szh commented May 10, 2024

Can you please signoff on your commits?

conjur-env/docker-compose.yml Outdated Show resolved Hide resolved
conjur-env/build.sh Outdated Show resolved Hide resolved
@szh
Copy link
Contributor

szh commented May 10, 2024

It's looking like we won't be able to get Windows support in our CI environment so quickly, and we don't want that to hold up merging this. We're going to need to arrange for the Windows tests to run locally only, and document how to run them in CONTRIBUTING.md.

@szh szh self-assigned this May 13, 2024
@szh
Copy link
Contributor

szh commented May 22, 2024

I just rebased on main

@szh
Copy link
Contributor

szh commented May 22, 2024

I've squashed the PR into a single commit

@szh szh linked an issue May 22, 2024 that may be closed by this pull request
Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ready to merge!

@szh szh merged commit 22730bb into cyberark:main May 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Adding windows stack support
2 participants