Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONJSE-1842: Update Go version #183

Merged
merged 2 commits into from
May 21, 2024
Merged

CONJSE-1842: Update Go version #183

merged 2 commits into from
May 21, 2024

Conversation

szh
Copy link
Contributor

@szh szh commented Mar 26, 2024

Desired Outcome

Update Golang and spring boot versions

Implemented Changes

Describe how the desired outcome above has been achieved with this PR. In
particular, consider:

  • What's changed? Why were these changes made?
  • How should the reviewer approach this PR, especially if manual tests are required?
  • Are there relevant screenshots you can add to the PR description?

Connected Issue/Story

Resolves #[relevant GitHub issue(s), e.g. 76]

CyberArk internal issue ID: [insert issue ID]

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@szh szh force-pushed the update-spring branch 2 times, most recently from a458db5 to 9e3302a Compare March 26, 2024 14:17
@szh szh force-pushed the update-spring branch from 9e3302a to c03c494 Compare May 17, 2024 18:13
@szh szh changed the title Update Spring Boot version in integration test Update Go version May 17, 2024
@szh szh self-assigned this May 17, 2024
@szh szh changed the title Update Go version CONJSE-1842: Update Go version May 17, 2024
@szh szh marked this pull request as ready for review May 17, 2024 18:42
@szh szh requested a review from a team as a code owner May 17, 2024 18:42
Copy link
Contributor

@john-odonnell john-odonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@szh szh merged commit 9a0fe56 into main May 21, 2024
2 checks passed
@szh szh deleted the update-spring branch May 21, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants