Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNJR-2127: Use Docker Compose v2 #181

Merged
merged 9 commits into from
May 9, 2024
Merged

CNJR-2127: Use Docker Compose v2 #181

merged 9 commits into from
May 9, 2024

Conversation

john-odonnell
Copy link
Contributor

Desired Outcome

Fix Jenkins pipeline by using Docker Compose v2

Implemented Changes

Replaces calls to docker-compose with docker compose

Connected Issue/Story

CyberArk internal issue ID: CNJR-2127

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@john-odonnell john-odonnell force-pushed the docker-compose-v2 branch 2 times, most recently from 5c6cf6c to 3f5e67f Compare December 15, 2023 18:09
@john-odonnell john-odonnell force-pushed the docker-compose-v2 branch 2 times, most recently from ad9684f to ed68a81 Compare December 15, 2023 19:28
@szh szh marked this pull request as ready for review May 2, 2024 13:23
@szh szh requested a review from a team as a code owner May 2, 2024 13:23
@szh szh self-assigned this May 9, 2024
@szh szh merged commit 85752b6 into main May 9, 2024
2 checks passed
@szh szh deleted the docker-compose-v2 branch May 9, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants