Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TAS 3.0, 4.0 and 5.0 #178

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Add support for TAS 3.0, 4.0 and 5.0 #178

merged 1 commit into from
Oct 17, 2023

Conversation

john-odonnell
Copy link
Contributor

@john-odonnell john-odonnell commented Oct 16, 2023

Desired Outcome

Update the buildpack to work with the latest TAS v3, v4 and v5.

Implemented Changes

  • Maintain support for cflinuxfs3 stack (used by TAS v3)
  • Add support for cflinuxfs4 stack (used by TAS v4 and v5)
  • Bump project Go version from 1.17.9 to 1.20.9, with support for 1.21.2

Connected Issue/Story

CyberArk internal issue ID: CNJR-2670

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

cflinuxfs4 and Go 1.20 are now project default.
Maintains support for cflinuxfs3 stack.
@john-odonnell john-odonnell changed the title Test tas 5.0 Add support for TAS 4.0 and 5.0 Oct 16, 2023
@john-odonnell john-odonnell marked this pull request as ready for review October 16, 2023 17:11
@john-odonnell john-odonnell requested a review from a team as a code owner October 16, 2023 17:11
@john-odonnell john-odonnell changed the title Add support for TAS 4.0 and 5.0 Add support for TAS 3.0, 4.0 and 5.0 Oct 16, 2023
Copy link
Contributor

@gl-johnson gl-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-odonnell john-odonnell merged commit 79942f8 into main Oct 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants