Reset accumulatedDamage #808 #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add variable damageCooldownTicks to Actor, in UpdateActorState reset Actor's accumulatedDamage if thier damageCooldownTicks is greater than GAME_TICKS_PER_SECOND (60).
cxong
reviewed
Dec 5, 2024
src/cdogs/actors.c
Outdated
| @@ -100,6 +100,7 @@ | |||
| #define GRIMACE_MELEE_TICKS 19 | |||
| #define DAMAGE_TEXT_DISTANCE_RESET_THRESHOLD (ACTOR_W / 2) | |||
| #define FOOTPRINT_MAX 8 | |||
| #define GAME_TICKS_PER_SECOND 60 // Assuming 60 ticks per second for accumulatedDamage reset | |||
There was a problem hiding this comment.
the game is 70FPS
please use FPS_FRAMELIMIT
replace GAME_TICKS_PER_SECOND with FPS_FRAMELIMIT.
|
looks good thanks! |
|
No problem, thank you for assistance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add variable damageCooldownTicks to Actor, in UpdateActorState reset Actor's accumulatedDamage if thier damageCooldownTicks is greater than GAME_TICKS_PER_SECOND (60).