Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

My variant of #466 #486

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

My variant of #466 #486

wants to merge 12 commits into from

Commits on Apr 9, 2017

  1. Adding rewrite and test examples from 2.12 to 2.11 with cats and scalaz

    @ShaneDelmore @cvogt
    ShaneDelmore authored and cvogt committed Apr 9, 2017
    Configuration menu
    Copy the full SHA
    78d0164 View commit details
    Browse the repository at this point in the history

  2. Demonstration of build api I have in my head.

    @ShaneDelmore @cvogt
    ShaneDelmore authored and cvogt committed Apr 9, 2017
    Configuration menu
    Copy the full SHA
    e4404db View commit details
    Browse the repository at this point in the history

  3. fix moduleKey cache keys to respect scalaVersion (otherwise cache 

    would contain wrong classLoader when switching scalaVersions)
    @cvogt
    cvogt committed Apr 9, 2017
    Configuration menu
    Copy the full SHA
    b0ab650 View commit details
    Browse the repository at this point in the history

  4. treat provided and runtime dependencies as mandatory ones for now 

    otherwise those libraries wouldn’t find the classes

we might have to reconsider this eventually
    @cvogt
    cvogt committed Apr 9, 2017
    Configuration menu
    Copy the full SHA
    82e5b41 View commit details
    Browse the repository at this point in the history

  5. flatClassLoader should probably only affect the classLoader used when 

    running something, not the one that may end up in a cache
    @cvogt
    cvogt committed Apr 9, 2017
    Configuration menu
    Copy the full SHA
    960d3fd View commit details
    Browse the repository at this point in the history

  6. disable DayDreaming

    @cvogt
    cvogt committed Apr 9, 2017
    Configuration menu
    Copy the full SHA
    0d25c34 View commit details
    Browse the repository at this point in the history

  7. name default build self name more clearly and refer to it’s fields 

    rather than the more obscure context object
    @cvogt
    cvogt committed Apr 9, 2017
    Configuration menu
    Copy the full SHA
    d7209c4 View commit details
    Browse the repository at this point in the history

  8. fixing cross-build-example tests to run across versions 

    (there is still a test failure, where the code hasn’t been
rewritten properly, but that’s ok. One step at a time.)
    @cvogt
    cvogt committed Apr 9, 2017
    Configuration menu
    Copy the full SHA
    7c1e2f4 View commit details
    Browse the repository at this point in the history

  9. All tests pass.

    @ShaneDelmore
    ShaneDelmore committed Apr 9, 2017
    Configuration menu
    Copy the full SHA
    4a6814d View commit details
    Browse the repository at this point in the history

  10. factor logic out into helpers

    @cvogt
    cvogt committed Apr 9, 2017
    Configuration menu
    Copy the full SHA
    ef93427 View commit details
    Browse the repository at this point in the history

  11. clean up cross-rewrite-example (more uniform)

    @cvogt
    cvogt committed Apr 9, 2017
    Configuration menu
    Copy the full SHA
    15c8859 View commit details
    Browse the repository at this point in the history

  12. format code (breaks rewrites!)

    @cvogt
    cvogt committed Apr 9, 2017
    Configuration menu
    Copy the full SHA
    c63a046 View commit details
    Browse the repository at this point in the history