Cleanup file structure, upper case Build.scala #273
Conversation
tim-zh
changed the title
|
There is a problem with producing a warning instead of an error when Build.scala is missing: |
| super(urls, parent); | ||
| assertExist(urls); | ||
| } | ||
| public CbtURLClassLoader(URL[] urls){ | ||
| public CbtUrlClassLoader(URL[] urls){ |
There was a problem hiding this comment.
Let's try to keep commits focused on one thing please. Renaming build.scala into Build.scala is pretty large and throwing in changes like this make them very hard to discover. Can you break this up into separate commits please?
|
regarding the warning: let's basically accept build.scala and Build.scala but show a warning by writing to System.err when build.scala is found. Since we'll accept it, we should have something to return, I believe? |
tim-zh
force-pushed
the
cleanup_file_structure
branch
from
7700467 to
174ceef
Compare
|
The update takes care of #274. |
tim-zh
force-pushed
the
cleanup_file_structure
branch
from
34a8bcb to
f9762f4
Compare
|
@tim-zh ah, I missed your updates. Just seeing them now. What do you think about using |
| @@ -20,62 +21,70 @@ trait BuildBuild extends BaseBuild{ | |||
|
|
|||
| override def dependencies = | |||
| super.dependencies :+ context.cbtDependency | |||
| def managedBuildDirectory: java.io.File = lib.realpath( projectDirectory.parent ) | |||
| def managedBuildDirectory: File = lib.realpath( projectDirectory.parent ) | |||
| private object managedBuildCache extends Cache[BuildInterface] | |||
| def managedBuild = managedBuildCache{ | |||
| val managedBuildFile = projectDirectory++"/Build.scala" | |||
There was a problem hiding this comment.
Instead of doing the below change, could we simple change this one val instead and show the warning if we are using build.scala here? Maybe easier than the nested if below.
There was a problem hiding this comment.
Agreed. I'll make it that way.
tim-zh
force-pushed
the
cleanup_file_structure
branch
from
f9762f4 to
823ef0c
Compare
tim-zh
force-pushed
the
cleanup_file_structure
branch
from
823ef0c to
50ee4c8
Compare
No description provided.