Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figured bass import and export for MusicXML and MEI #1613

Open
wants to merge 75 commits into
base: master
Choose a base branch
from
Open

Figured bass import and export for MusicXML and MEI #1613

wants to merge 75 commits into from

Commits on Feb 26, 2023

  1. added figuredBass tag to mei import

    Moritz Heffter committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    48d216d View commit details
    Browse the repository at this point in the history

  2. fixed import and moved figuredBassIndication to harmony

    Moritz Heffter committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    b3249a9 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #2 from mxordn/mei-import-fb-support 

    fixed import and moved figuredBassIndication to harmony
    @mxordn
    mxordn authored Feb 26, 2023
    Configuration menu
    Copy the full SHA
    59d54c0 View commit details
    Browse the repository at this point in the history

  4. added meterSig to mei import

    Moritz Heffter committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    afcde73 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. first working musicxml output for FiguredBassIndication Objects

    Moritz Heffter committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    7ca3834 View commit details
    Browse the repository at this point in the history

  2. improved figuredbass mei and musicxml import/export deals now with ex… 

    …tenders
    Moritz Heffter committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    79ab796 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'cuthbertLab:master' into mei-import-fb-support

    @mxordn
    mxordn authored Feb 28, 2023
    Configuration menu
    Copy the full SHA
    8fe69ed View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2023

  1. stable import and export of figured base. Some unicode characters mig… 

    …ht have to be added in the future
    Moritz Heffter committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    fe3aaf5 View commit details
    Browse the repository at this point in the history

  2. cleanup mei import and musicxml export

    Moritz Heffter committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    7708338 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #3 from mxordn/mei-import-fb-support 

    Mei import fb support
    @mxordn
    mxordn authored Mar 4, 2023
    Configuration menu
    Copy the full SHA
    0793349 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. xml import and export fixed problems with more than two figures per note

    Moritz Heffter committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    82995d7 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Merge pull request #4 from cuthbertLab/master 

    Add utility for removing duplicated objects (e.g. keys, clefs) (cuthbertLab#1454)
    @mxordn
    mxordn authored Mar 21, 2023
    Configuration menu
    Copy the full SHA
    60653c1 View commit details
    Browse the repository at this point in the history

  2. fixed wrong offsets for multiple figures

    Moritz Heffter committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    0cabb7d View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. fixed export of multiple figures, where an already exsiting duration … 

    …was erroneously set to 0
    Moritz Heffter committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    fd1626d View commit details
    Browse the repository at this point in the history

  2. cleaned upcomments and stuff

    Moritz Heffter committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    874b959 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #5 from mxordn/musicxml-fb-import 

    Musicxml fb import
    @mxordn
    mxordn authored Mar 22, 2023
    Configuration menu
    Copy the full SHA
    7c62238 View commit details
    Browse the repository at this point in the history

  4. added support for prefix tags and solved problems with empty number tags

    Moritz Heffter committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    a85aeeb View commit details
    Browse the repository at this point in the history

  5. figured bass is now checked

    Moritz Heffter committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    ffc6190 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. updated mei/base.py

    Moritz Heffter committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    9acd4a6 View commit details
    Browse the repository at this point in the history

  2. mei/base.py recent update to upstream

    Moritz Heffter committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    1c11c71 View commit details
    Browse the repository at this point in the history

  3. full merge of mei/base.py

    Moritz Heffter committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    13d0d59 View commit details
    Browse the repository at this point in the history

  4. edit in mei/test_base.py to pass new fb element in part list

    Moritz Heffter committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    f065d4c View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. suggestions from review added, smaller formatting improvements

    Moritz Heffter committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    389bb82 View commit details
    Browse the repository at this point in the history

  2. adapted tests in mei/test_base-py and doctest for figuredBass/notatio… 

    …n.py
    Moritz Heffter committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    2fb6285 View commit details
    Browse the repository at this point in the history

  3. simplification of a if else statement from review

    Moritz Heffter committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    4e5fdec View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. finally cleaned up for tests and flake8 and mypy

    Moritz Heffter committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    ad8b09d View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Update music21/musicxml/xmlToM21.py 

    Co-authored-by: Jacob Walls <[email protected]>
    @mxordn @jacobtylerwalls
    mxordn and jacobtylerwalls authored Mar 30, 2023
    Configuration menu
    Copy the full SHA
    695a1e9 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2023

  1. refactoring and adding testfles. put figures in measure-

    Moritz Heffter committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    3e5074f View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. added figuredBass tag to mei import

    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    27a1c44 View commit details
    Browse the repository at this point in the history

  2. fixed import and moved figuredBassIndication to harmony

    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    621aef3 View commit details
    Browse the repository at this point in the history

  3. added meterSig to mei import

    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    7e416cf View commit details
    Browse the repository at this point in the history

  4. first working musicxml output for FiguredBassIndication Objects

    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    8085310 View commit details
    Browse the repository at this point in the history

  5. improved figuredbass mei and musicxml import/export deals now with ex… 

    …tenders
    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    f10cbb9 View commit details
    Browse the repository at this point in the history

  6. stable import and export of figured base. Some unicode characters mig… 

    …ht have to be added in the future
    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    52363bc View commit details
    Browse the repository at this point in the history

  7. cleanup mei import and musicxml export

    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    413c17b View commit details
    Browse the repository at this point in the history

  8. xml import and export fixed problems with more than two figures per note

    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    8244b3e View commit details
    Browse the repository at this point in the history

  9. fixed wrong offsets for multiple figures

    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    f9179f7 View commit details
    Browse the repository at this point in the history

  10. fixed export of multiple figures, where an already exsiting duration … 

    …was erroneously set to 0
    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    3649265 View commit details
    Browse the repository at this point in the history

  11. cleaned upcomments and stuff

    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    e497210 View commit details
    Browse the repository at this point in the history

  12. added support for prefix tags and solved problems with empty number tags

    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    c6ac193 View commit details
    Browse the repository at this point in the history

  13. figured bass is now checked

    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    d8cef56 View commit details
    Browse the repository at this point in the history

  14. updated mei/base.py

    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    4f098b1 View commit details
    Browse the repository at this point in the history

  15. mei/base.py recent update to upstream

    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    9717173 View commit details
    Browse the repository at this point in the history

  16. full merge of mei/base.py

    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    0f4aba5 View commit details
    Browse the repository at this point in the history

  17. edit in mei/test_base.py to pass new fb element in part list

    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    c8318c5 View commit details
    Browse the repository at this point in the history

  18. suggestions from review added, smaller formatting improvements

    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    7076597 View commit details
    Browse the repository at this point in the history

  19. adapted tests in mei/test_base-py and doctest for figuredBass/notatio… 

    …n.py
    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    d6c49db View commit details
    Browse the repository at this point in the history

  20. simplification of a if else statement from review

    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    9688055 View commit details
    Browse the repository at this point in the history

  21. finally cleaned up for tests and flake8 and mypy

    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    97882bc View commit details
    Browse the repository at this point in the history

  22. Update music21/musicxml/xmlToM21.py 

    Co-authored-by: Jacob Walls <[email protected]>
    @mxordn @jacobtylerwalls
    2 people authored and Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    dcd1477 View commit details
    Browse the repository at this point in the history

  23. rebase 8.3

    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    1164fd9 View commit details
    Browse the repository at this point in the history

  24. added function documentation strings with examples

    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    59974de View commit details
    Browse the repository at this point in the history

  25. added more documentation in the mei parser

    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    a1efced View commit details
    Browse the repository at this point in the history

  26. Merge branch 'master' into test-figured-bass

    @mxordn
    mxordn authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    000b4ea View commit details
    Browse the repository at this point in the history

  27. Merge pull request #7 from mxordn/test-figured-bass 

    Test figured bass merged into master
    @mxordn
    mxordn authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    91c712d View commit details
    Browse the repository at this point in the history

  28. mei commit

    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    95c57fd View commit details
    Browse the repository at this point in the history

  29. Merge branch 'test-figured-bass' of https://github.com/mxordn/music21 … 

    …into test-figured-bass
    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    08edf89 View commit details
    Browse the repository at this point in the history

  30. Merge pull request #8 from mxordn/test-figured-bass 

    Test figured bass
    @mxordn
    mxordn authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    21469bc View commit details
    Browse the repository at this point in the history

  31. resolve two merge conflicts

    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    86c95be View commit details
    Browse the repository at this point in the history

  32. Merge branch 'master' of https://github.com/mxordn/music21

    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    dd0de78 View commit details
    Browse the repository at this point in the history

  33. version with Figures at top level

    Moritz Heffter committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    7b2d99a View commit details
    Browse the repository at this point in the history

  34. Merge pull request #9 from mxordn/test-figured-bass 

    version with Figures at top level
    @mxordn
    mxordn authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    e008660 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. added some additional checks and warnings for prefixes and suffixes

    mxordn committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    704434f View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. added prefix and suffix warnings

    mxordn committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    1f2d4ce View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2023

  1. Merge branch 'cuthbertLab:master' into master

    @mxordn
    mxordn authored Jun 17, 2023
    Configuration menu
    Copy the full SHA
    a3bd064 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'cuthbertLab:master' into test-figured-bass

    @mxordn
    mxordn authored Jun 17, 2023
    Configuration menu
    Copy the full SHA
    cf1f237 View commit details
    Browse the repository at this point in the history

  3. added examples for figured bass

    mxordn committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    74f4d96 View commit details
    Browse the repository at this point in the history

  4. mei import of figured bass goes to the measure; added exmaples for me… 

    …i figured bass
    Moritz Heffter committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    0d91795 View commit details
    Browse the repository at this point in the history

  5. commented out old mei import into score

    Moritz Heffter committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    3e45f77 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'cuthbertLab:master' into test-figured-bass

    @mxordn
    mxordn authored Jun 17, 2023
    Configuration menu
    Copy the full SHA
    b5d7201 View commit details
    Browse the repository at this point in the history

  7. added modified tests

    mxordn committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    f62fc34 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'cuthbertLab:master' into master

    @mxordn
    mxordn authored Jun 17, 2023
    Configuration menu
    Copy the full SHA
    774c126 View commit details
    Browse the repository at this point in the history

  9. Merge pull request #10 from mxordn/test-figured-bass 

    Test figured bass
    @mxordn
    mxordn authored Jun 17, 2023
    Configuration menu
    Copy the full SHA
    03ca64e View commit details
    Browse the repository at this point in the history

  10. cleanup comments

    mxordn committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    36970de View commit details
    Browse the repository at this point in the history

  11. second cleanup comments and tests

    mxordn committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    a4b523e View commit details
    Browse the repository at this point in the history