Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving vertx dependency issues with webpack #510

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

trylaarsdam
Copy link

What I’ve changed:
In /lib/env.js, the vertx require statement now uses @vertx/core, which is the node package for vertx. This resolves an issue when using webpack (see #482)
package.json has also been updated to include @vertx/core as a dependency.

@trylaarsdam trylaarsdam marked this pull request as ready for review January 15, 2021 17:27
@o0101
Copy link

o0101 commented Aug 9, 2022

please merge, as the workaround involves:

new webpack.NormalModuleReplacementPlugin(
  /^vertx/,
  '@vertx/core',
)

And npm i --save-dev @vertx/core

from: https://stackoverflow.com/a/71458295/10283964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants