Make subscribe callbacks optional in typings #548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update docs and typescript typings to reflect that methods on the
Observer
all are optional.Here is what is linked in the docs regarding the
Observer
: https://github.com/tc39/proposal-observable#observerFlow types seem to be correct already.
most/src/index.js.flow
Lines 50 to 55 in bfed148
Todo
Unit tests for new or changed APIs and/or functionality