Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addAspectToMatches to work also with classes #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

avilaviad
Copy link

Applying aspect over a class doesn't work. This is caused by the fact that the methods added to the prototypes of the ES2015 classes are not enumerable but addAspectToMatches is using for..in in order to get them.

I solved this by @mgechev suggestion and used Object.getOwnPropertyNames to get all class's methods, traverse them and check if they're function and match the pointcut.

It's my first pull request here in github so sorry if I missed anything or did something wrong in the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant