Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostStepHook is what I think AfterStepHook ought to have been - https://github.com/cucumber/godog/issues/633 #634

Closed
wants to merge 11 commits into from

Conversation

Johnlon
Copy link
Member

@Johnlon Johnlon commented Jun 21, 2024

See #633

🤔 What's changed?

#633 covers the proposal.

AfterStepHook doesn't allow full manipulation of the test outcome, so added PostStepHook to compensate without breaking compat.

⚡️ What's your motivation?

I need full control over the test outcome from a hook and the AfterStepHook does not permit that.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

To be honest I'd rather just introduct a breaking change and replace the logic of AfterStep with my proposed PostStep.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • [x ] I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • [ x] My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • [ x] Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

I've added an _example but not figured out the testing.

@Johnlon
Copy link
Member Author

Johnlon commented Jul 23, 2024

Not going to progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant