The VolumeGroup specification contains a few minor mistakes #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nixpanic
commented
Jul 25, 2024
nixpanic
commented
- volumegroup: description should mention MODIFY_VOLUME_GROUP
- volumegroup: correct comment got the ControllerGetVolumeGroup RPC call
nixpanic
changed the title
nixpanic
force-pushed
the
volumegroup/corrections
branch
from
9e4d695
to
b96369e
Compare
Madhu-1
approved these changes
Jul 26, 2024
iPraveenParihar
approved these changes
Aug 5, 2024
|
@Mergifyio refresh |
❌ Command disallowed due to command restrictions in the Mergify configuration.
|
|
@Mergifyio refresh |
✅ Pull request refreshed |
iPraveenParihar
approved these changes
Aug 5, 2024
Rakshith-R
approved these changes
Aug 5, 2024
The ModifyVolumeGroupMembership procedure description refers to the MODIFY_VOLUME_GROUP_MEMBERSHIP capability, but that does not exist. The capability that is available in the IdentityService is MODIFY_VOLUME_GROUP. Signed-off-by: Niels de Vos <[email protected]>
The comment mentions CreateVolumeGroup, which should be ControllerGetVolumeGroup. Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
nixpanic
force-pushed
the
volumegroup/corrections
branch
from
b96369e
to
1aedc8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.