ci: remove GITHUB_TOKEN from linter workflow
#56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpanic
force-pushed
the
workflow/super-linter/write
branch
from
79fd6ab
to
24853b0
Compare
|
These changes are not sufficient yet, the linter still reports
|
nixpanic
force-pushed
the
workflow/super-linter/write
branch
3 times, most recently
from
bc89166
to
a67b08a
Compare
nixpanic
changed the title
GITHUB_TOKEN from linter workflow
Madhu-1
approved these changes
Jun 29, 2023
Linter logs contain lots of errors like these:
[INFO] ERROR! Failed to call GitHub Status API!
[INFO] ERROR:[curl: (22) The requested URL returned error: 403]
By removing the `GITHUB_TOKEN` option, only the general result of the
linter is added to the PR status. There is no need to try and set the
status if it always fails, and the warnings can look confusing.
Signed-off-by: Niels de Vos <[email protected]>
nixpanic
force-pushed
the
workflow/super-linter/write
branch
from
a67b08a
to
d06f3fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linter logs contain lots of errors like these:
By removing the
GITHUB_TOKEN, no unknown status updates will be set, so the errors are gone.