adding vg api

[matancarmeli7]

No description provided.

[nixpanic]

There could be many more comments in the go-code. A description of the PR is missing, and would be nice to have references to the CSI/Kubernetes proposals.

[nixpanic]

this should not be part of this commit anymore once csi-addons/spec#54 is merged

[matancarmeli7]

agreed, I will change it once the PR in the spec will be changed

[nixpanic]

this can be corrected now

[nixpanic]

@Mergifyio rebase

[mergify]

rebase

❌ Base branch update has failed

Git reported the following error:

Rebasing (1/1)
Auto-merging config/crd/bases/csiaddons.openshift.io_reclaimspacecronjobs.yaml
Auto-merging deploy/controller/crds.yaml
CONFLICT (content): Merge conflict in deploy/controller/crds.yaml
Auto-merging deploy/controller/install-all-in-one.yaml
CONFLICT (content): Merge conflict in deploy/controller/install-all-in-one.yaml
Auto-merging go.mod
Auto-merging go.sum
Auto-merging vendor/modules.txt
error: could not apply b808ddeb... adding vg api
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply b808ddeb... adding vg api

err-code: 35C31

[nixpanic]

There most likely are functions under controllers/volumegroup.storage/utils that are available somewhere else, or would be suitable for other controllers too. This should probably be cleaned up at a later time.

At the moment I am missing how the communication to the CSI-driver is done. The kubernetes-csi-addons operator communicates over gRPC to the csi-addons-sidecar. The sidecar can be running alongside the CSI-controller (provisioner) or the CSI-nodeplugin. VolumeGroups most likely need to only call function of the CSI-controller. The protocol between the operator and sidecar should be rather simple as the sidecar can resolve the Kubernetes objects (PVC, PV, Secrets, ...). There is no .proto file added for this communication under https://github.com/csi-addons/kubernetes-csi-addons/tree/main/internal/proto , which is what I would expect.

[nixpanic]

maybe write this like

switch cap.GetVolumeGroup().GetType() {

There is no use for capType as additional variable.

[nixpanic]

this can be corrected now

[nixpanic]

This is too complex to include, #588 is a simpler API that lets CSI-drivers handle the grouping of volumes how they like.