Skip to content

Commit

Permalink
Updates acc to the reviews
Browse files Browse the repository at this point in the history
Signed-off-by: Niraj Yadav <[email protected]>
  • Loading branch information
black-dragon74 committed Jul 4, 2024
1 parent 0477919 commit 5a7b44c
Show file tree
Hide file tree
Showing 5 changed files with 115 additions and 120 deletions.
2 changes: 1 addition & 1 deletion cmd/csi-addons/encryptionkeyrotation.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func (ekr *EncryptionKeyRotation) Execute() error {
kc := getKubernetesClient()
ekrs := service.NewEncryptionKeyRotationServer(ekr.Client, kc)

ekrReq := &proto.EncKeyRotateRequest{
ekrReq := &proto.EncryptionKeyRotateRequest{
PvName: ekr.persistentVolume,
}

Expand Down
94 changes: 47 additions & 47 deletions internal/proto/encryptionkeyrotation.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 14 additions & 15 deletions internal/proto/encryptionkeyrotation.proto
Original file line number Diff line number Diff line change
@@ -1,24 +1,23 @@
syntax = "proto3";
package encryptionkeyrotation;
package proto;

option go_package = "github.com/csi-addons/kubernetes-csi-addons/internal/proto";

// EncKeyRotation holds the RPC method for running
// key rotation operation on the volume.
service EncKeyRotation {
rpc EncKeyRotate(EncKeyRotateRequest)
returns (EncKeyRotateResponse){}
// EncryptionKeyRotation holds the RPC method for running
// key rotation operation on the pv.
service EncryptionKeyRotation {
rpc EncryptionKeyRotate(EncryptionKeyRotateRequest)
returns (EncryptionKeyRotateResponse){}
}
// EncKeyRotateRequest contains the information needed to identify
// the volume by the SP and access any backend services so that the key can be
// rotated.
message EncKeyRotateRequest {
// EncryptionKeyRotateRequest contains the information needed to identify
// the volume by the csi-addons sidecar and access any backend services so that the
// key can be rotated.
message EncryptionKeyRotateRequest {
// The name of the pv
// This field is required
string pv_name = 1;
}
// EncKeyRotateResponse holds the information about the result of the
// EncKeyRotateRequest call.
message EncKeyRotateResponse {

}
// EncryptionKeyRotateResponse holds the information about the result of the
// EncryptionKeyRotateRequest call.
message EncryptionKeyRotateResponse {
}
82 changes: 41 additions & 41 deletions internal/proto/encryptionkeyrotation_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 5a7b44c

Please sign in to comment.