Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xtyll/return on first response #100

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Xtyll
Copy link

@Xtyll Xtyll commented Jul 22, 2023

  • [] I have added parameter return_on_first_response to write and get_response methods. With this parameter GbdController return the first received response without adidtional waiting

Summary of changes

Test plan

Tested by running

nox -s tests

The separate test added (test_return_on_first_response). The test set timeout to 10s without additional delay and perform one simple stepi operation. To test pass we expect that response will generated faster than defined timeout

@Xtyll
Copy link
Author

Xtyll commented Jul 22, 2023

@cs01 @barisione could you check it please?

@barisione
Copy link
Collaborator

I'm not really familiar with gdbcontroller and friends so @cs01 would be better (if you can find the time for it!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants