Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flags missing from termios #14652

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gergelyk
Copy link

@gergelyk gergelyk commented Jun 1, 2024

Adding flags from c_cc characters section. Refer to https://sites.uclouvain.be/SystInfo/usr/include/bits/termios.h.html

Copy link
Contributor

@ysbaddaden ysbaddaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few issues to solve beforehand:

@gergelyk
Copy link
Author

I agree. The only flag that I was missing in this project in fact was VTIME. It seems to be part of non-canonical mode, like VSTART, VSTOP, etc. What do you think? Should this PR include only VTIME?

@straight-shoota
Copy link
Member

There's an ongoing discussion about the status of libc bindings in stdlib (#13504). The general idea is that we don't plan to support any bindings that are not used in stdlib itself. Unused bindings might be removed in the future (#11955). So I don't think it's a good idea to add more unused bindings at this point.
This discussion is not finialized and might come to a different conclusion after all (though I doubt it).

If you need specific bindings for your project, it's probably best to define them in your own code.

@ysbaddaden
Copy link
Contributor

(I really should just restart my posix shard as a libc shard, with libvirt VMs to autogenerate the bindings for all supported targets)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants