Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent side effects with Dir, File and FileUtils #91

Conversation

crabonature
Copy link

PR for #90.

@jwoertink
Copy link
Collaborator

Hey! thanks for submitting the PR. I'll take a look over this. One thing I am wondering just off the top of my head, when you check the with_persistent_side_effect, I'm wondering if any File operation would also fall in to this.

@crabonature
Copy link
Author

So I checked File and FileUtils and this ones will be falling into this too:

File.delete(), File.link(), File.rename(), File.symlink()
FileUtils.mkdir(), FileUtils.mkdir_p(), FileUtils.mv(),
FileUtils.rm, FileUtils.rm_r(), FileUtils.rm_rf(), FileUtils.rmdir()

@crabonature crabonature changed the title Persistent side effects with Dir Persistent side effects with Dir, File and FileUtils Feb 11, 2018
@veelenga
Copy link
Member

veelenga commented Mar 13, 2018

@jwoertink @crabonature I don't think this is the right approach to handle it. We already added it to the list of side effects. Unfortunately, this is the best we can do here unless ICR becomes a real REPL #79

@veelenga
Copy link
Member

Closing it. Please do not hesitate to continue the discussion if you have something to say. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants