Feature/#98 change vault init #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overheadhunter
requested changes
Mar 15, 2021
overheadhunter
requested changes
Mar 16, 2021
overheadhunter
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #98
Implemented Solution
With this PR, the content root of a vault will be exclusivley created during the vault initialization, i.e. in the static
CryptoFileSystemProvider.initialize(Path vaultPath)method and never implicitily during CryptoFileSystem(Impl) creation.Additionally, when creating a new CryptoFileSystem in the
CryptoFileSystemsclass, the existence of the vault content root is checked before the the filesystem is actually constructed and an IOException raised, if the check fails.