Add more tests #178
Draft
Add more tests #178
+358
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaniruTEC
force-pushed
the
feature/more-tests
branch
from
30939e8
to
8b61544
Compare
Verified that `Files#delete` is supposed to throw a NoSuchFileException if no file can be found.
infeo
reviewed
Oct 17, 2023
Comment on lines
+209
to
+251
| @DisplayName("Delete directory while and after containing multiple elements") | ||
| @ParameterizedFileTest | ||
| public void testDeleteDirMultipleNagging(String targetName) throws IOException { | ||
| try (var fs = setupCryptoFs(50, 100, false)) { | ||
| var targetDir = fs.getPath("/" + targetName); | ||
| Files.createDirectory(targetDir); | ||
|
|
||
| var nestedFile = targetDir.resolve("nestedFile"); | ||
| Files.createFile(nestedFile); | ||
| var nestedDir = targetDir.resolve("nestedDir"); | ||
| Files.createDirectory(nestedDir); | ||
| var nestedLink = targetDir.resolve("nestedLink"); | ||
| Files.createSymbolicLink(nestedLink, fs.getPath("linkTarget")); | ||
|
|
||
| assertThrows(DirectoryNotEmptyException.class, () -> Files.delete(targetDir)); | ||
| assertTrue(Files.exists(targetDir, LinkOption.NOFOLLOW_LINKS)); | ||
| assertTrue(Files.exists(nestedFile, LinkOption.NOFOLLOW_LINKS)); | ||
| assertTrue(Files.exists(nestedDir, LinkOption.NOFOLLOW_LINKS)); | ||
| assertTrue(Files.exists(nestedLink, LinkOption.NOFOLLOW_LINKS)); | ||
|
|
||
| assertDoesNotThrow(() -> Files.delete(nestedFile)); | ||
| assertThrows(DirectoryNotEmptyException.class, () -> Files.delete(targetDir)); | ||
| assertTrue(Files.exists(targetDir, LinkOption.NOFOLLOW_LINKS)); | ||
| assertTrue(Files.notExists(nestedFile, LinkOption.NOFOLLOW_LINKS)); | ||
| assertTrue(Files.exists(nestedDir, LinkOption.NOFOLLOW_LINKS)); | ||
| assertTrue(Files.exists(nestedLink, LinkOption.NOFOLLOW_LINKS)); | ||
|
|
||
| assertDoesNotThrow(() -> Files.delete(nestedDir)); | ||
| assertThrows(DirectoryNotEmptyException.class, () -> Files.delete(targetDir)); | ||
| assertTrue(Files.exists(targetDir, LinkOption.NOFOLLOW_LINKS)); | ||
| assertTrue(Files.notExists(nestedDir, LinkOption.NOFOLLOW_LINKS)); | ||
| assertTrue(Files.exists(nestedLink, LinkOption.NOFOLLOW_LINKS)); | ||
|
|
||
| assertDoesNotThrow(() -> Files.delete(nestedLink)); | ||
| assertTrue(Files.exists(targetDir, LinkOption.NOFOLLOW_LINKS)); | ||
| assertTrue(Files.notExists(nestedLink, LinkOption.NOFOLLOW_LINKS)); | ||
|
|
||
| assertDoesNotThrow(() -> Files.delete(targetDir)); | ||
| assertTrue(Files.notExists(targetDir, LinkOption.NOFOLLOW_LINKS)); | ||
|
|
||
| assertThrows(NoSuchFileException.class, () -> Files.delete(targetDir)); | ||
| } | ||
| } |
There was a problem hiding this comment.
What is the rationale behind this test?
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more tests for cryptofs.