-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vite-plugin-docs getting-started with crxjs install step #960
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 9b57aa3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Should |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swkidd I agree about adding @beta
to the install commands, I've popped those changes in as suggestions.
updated to reflect that 'type: module' needs to be added a project'spackage.json file for it run correctly
That would be great!
packages/vite-plugin-docs/docs/getting-started/react/00-create-project.md
Outdated
Show resolved
Hide resolved
packages/vite-plugin-docs/docs/getting-started/vanilla-js/00-create-project.md
Outdated
Show resolved
Hide resolved
packages/vite-plugin-docs/docs/getting-started/vue/00-create-project.md
Outdated
Show resolved
Hide resolved
…-project.md Co-authored-by: Jack Steam <[email protected]>
…reate-project.md Co-authored-by: Jack Steam <[email protected]>
…roject.md Co-authored-by: Jack Steam <[email protected]>
@jacksteamdev I've updated the PR with the package.json |
Ticket
#955
#952
What
Add
as an install step for react, vanilla-js and vue