fix: maintain ; and , during minification (#590)

Co-authored-by: Jack Steam <[email protected]>
crxjs · Nov 27, 2022 · badc910 · badc910
1 parent 5ac019d
commit badc910
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/fluffy-numbers-brake.md b/.changeset/fluffy-numbers-brake.md
@@ -0,0 +1,5 @@
+---
+"@crxjs/vite-plugin": patch
+---
+
+fix: maintain ; and , during minification
diff --git a/packages/vite-plugin/src/node/plugin-contentScripts_dynamic.ts b/packages/vite-plugin/src/node/plugin-contentScripts_dynamic.ts
@@ -152,7 +152,7 @@ export const pluginDynamicContentScripts: CrxPluginFn = () => {
 
                   return `${JSON.stringify(
                     `/${script.loaderName ?? script.fileName}`,
-                  )};`
+                  )}${match.split(scriptKey)[1]}`
                 },
               )
               // TODO: remove unused import_meta value?

diff --git a/...te-plugin/tests/out/vite-dynamic-script-resources-minify/__snapshots__/build.test.ts.snap b/...te-plugin/tests/out/vite-dynamic-script-resources-minify/__snapshots__/build.test.ts.snap
@@ -45,7 +45,7 @@ Array [
 `;
 
 exports[`build fs output > assets/background.ts.hash5.js 1`] = `
-"const t=\\"/assets/content1.ts-loader.hash6.js\\";e=\\"/assets/content2.ts-loader.hash7.js\\";chrome.scripting.executeScript({files:[t,e],target:{tabId:1}});
+"const t=\\"/assets/content1.ts-loader.hash6.js\\",e=\\"/assets/content2.ts-loader.hash7.js\\";chrome.scripting.executeScript({files:[t,e],target:{tabId:1}});
 "
 `;
-Original file line number
+Diff line change
@@ Expand Up / @@ -45,7 +45,7 @@ Array [ @@
     `;
     exports[`build fs output > assets/background.ts.hash5.js 1`] = `
-    "const t=\\"/assets/content1.ts-loader.hash6.js\\";e=\\"/assets/content2.ts-loader.hash7.js\\";chrome.scripting.executeScript({files:[t,e],target:{tabId:1}});
+    "const t=\\"/assets/content1.ts-loader.hash6.js\\",e=\\"/assets/content2.ts-loader.hash7.js\\";chrome.scripting.executeScript({files:[t,e],target:{tabId:1}});
     "
     `;
@@ Expand Down @@