Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bouncer registration via secrets #3275

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

victorpsantos
Copy link

Previously, the code was using awk -F "/" '{printf $NF}' | cut -d_ -f2- to extract the bouncer name from the secret file path. However, this was causing an issue where the bouncer name was being extracted incorrectly.

The fix is to change cut -d_ -f2- to cut -d_ -f3-, so that the bouncer name is extracted correctly.

Copy link

github-actions bot commented Oct 3, 2024

@victorpsantos: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Oct 3, 2024

@victorpsantos: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@victorpsantos victorpsantos marked this pull request as draft October 3, 2024 13:38
@victorpsantos victorpsantos marked this pull request as ready for review October 3, 2024 13:43
@victorpsantos
Copy link
Author

/kind fix
/area configuration

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.21%. Comparing base (9976616) to head (7ac22d5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3275   +/-   ##
=======================================
  Coverage   39.21%   39.21%           
=======================================
  Files         480      480           
  Lines       62075    62075           
=======================================
+ Hits        24341    24345    +4     
+ Misses      35091    35087    -4     
  Partials     2643     2643           
Flag Coverage Δ
bats 31.44% <ø> (+0.07%) ⬆️
unit-linux 34.72% <ø> (ø)
unit-windows 24.65% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buixor buixor added this to the 1.6.5 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants