fix(aws): Add missing api groups setup functions #1883
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #1874 by adding missing setup functions.
It appears #1827 missed a few api groups during the refactor.
To identify missing groups I simply ran
find pkg/controller -name 'setup.go' -maxdepth 2 | sort
and compared to the existingaws.go
file and added missing lines. Not sure if I missed anything else so happy to hear feedback on the approach.I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
After making my changes and running the provider locally I've executed:
And saw successful handling of DynamoDB resources: