Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws): Add missing api groups setup functions #1883

Conversation

strazeadin
Copy link
Contributor

Description of your changes

Fixes #1874 by adding missing setup functions.

It appears #1827 missed a few api groups during the refactor.

To identify missing groups I simply ran find pkg/controller -name 'setup.go' -maxdepth 2 | sort and compared to the existing aws.go file and added missing lines. Not sure if I missed anything else so happy to hear feedback on the approach.

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

After making my changes and running the provider locally I've executed:

kubectl apply -f examples/dynamodb/table.yaml

And saw successful handling of DynamoDB resources:

NAME                                                                     READY   SYNCED   EXTERNAL-NAME
table.dynamodb.aws.crossplane.io/sample-table                            True    True     sample-table
table.dynamodb.aws.crossplane.io/sample-table-global-secondary-indexes   True    True     sample-table-global-secondary-indexes
table.dynamodb.aws.crossplane.io/sample-table-ppr                        True    True     sample-table-ppr
table.dynamodb.aws.crossplane.io/sample-table-with-sse                   True    True     sample-table-with-sse
table.dynamodb.aws.crossplane.io/sample-table-without-sse                True    True     sample-table-without-sse

Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @strazeadin for fixing this!

@MisterMX MisterMX merged commit 34480f9 into crossplane-contrib:master Oct 5, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamoDB broken
2 participants