feat(iam): Add ServiceLinkedRole #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haarchri
force-pushed
the
feature/servicelinkedrole
branch
from
ee2633d
to
903bed9
Compare
|
@muvaf as discussed here the PR for IAM Group - with the region field as described here aws-controllers-k8s/community#1150 |
ack-bot
pushed a commit
to aws-controllers-k8s/code-generator
that referenced
this pull request
Feb 7, 2022
Signed-off-by: haarchri <[email protected]> Issue #, if available: aws-controllers-k8s/community#1150 Description of changes: skip region for `.APIGroup "iam.aws.crossplane.io"` tested locally with crossplane-contrib/provider-aws#1118 - it is working now By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
|
First we need to merge #1122 and then we can bump the ack-code-gen commit again |
haarchri
force-pushed
the
feature/servicelinkedrole
branch
from
903bed9
to
4c3542f
Compare
|
rebased & ready for review |
muvaf
reviewed
Mar 8, 2022
MisterMX
changed the title
MisterMX
changed the title
MisterMX
force-pushed
the
feature/servicelinkedrole
branch
2 times, most recently
from
8158858
to
7744114
Compare
Signed-off-by: haarchri <[email protected]> Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <[email protected]> Co-authored-by: Maximilian Blatt (external expert on behalf of DB Netz) <[email protected]> Add status info and check if role is actually a service-linked role.
MisterMX
force-pushed
the
feature/servicelinkedrole
branch
from
7744114
to
f5113f4
Compare
tektondeploy
pushed a commit
to gtn3010/provider-aws
that referenced
this pull request
Mar 12, 2024
…sion-crds-conversions Add conversion functions for handling some breaking API changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: haarchri [email protected]
Description of your changes
added IAM ServiceLinkedRole
Fixes #479
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested