Skip to content

Commit

Permalink
Merge pull request #1811 from wotolom/dbinstance-remove-lateinit-engi…
Browse files Browse the repository at this point in the history
…neversion

fix(rds/dbinstance): remove minor engineVersion lateinit
  • Loading branch information
MisterMX authored Jul 21, 2023
2 parents 8c53ead + 45e26bc commit 61cc228
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions pkg/controller/rds/dbinstance/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -267,12 +267,6 @@ func lateInitialize(in *svcapitypes.DBInstanceParameters, out *svcsdk.DescribeDB
in.StorageEncrypted = aws.LateInitializeBoolPtr(in.StorageEncrypted, db.StorageEncrypted)
in.StorageType = aws.LateInitializeStringPtr(in.StorageType, db.StorageType)
in.EngineVersion = aws.LateInitializeStringPtr(in.EngineVersion, db.EngineVersion)
// When version 5.6 is chosen, AWS creates 5.6.41 and that's totally valid.
// But we detect as if we need to update it all the time. Here, we assign
// the actual full version to our spec to avoid unnecessary update signals.
if strings.HasPrefix(aws.StringValue(db.EngineVersion), aws.StringValue(in.EngineVersion)) {
in.EngineVersion = db.EngineVersion
}
if in.DBParameterGroupName == nil {
for i := range db.DBParameterGroups {
if db.DBParameterGroups[i].DBParameterGroupName != nil {
Expand Down

0 comments on commit 61cc228

Please sign in to comment.