-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Implements a scroll-to-top element for longer page contexts #97
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for vocabulary-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi and thanks for this! In addition to the changes listed above, the button is flush to the right edge and should instead be aligned further into and possibly over the content area. The button also needs to be an element that could occur within the HTML of every page, but only become visible on longer pages. Please see the original Issue on the mention of pseudo classes to obscure the element.
|
@possumbilities thank you for taking your time to review this PR. I have noted all changes and concerns. I will get to work on implementing them Immedidately |
@possumbilities I have implemented all feedback given. I have also implemented it in such a way to it can be added to any page implementing vocabulary. It is hidden on shorter pages, and appears on longer pages without the use of JS. I have also implemented it in all specimens, and updated the |
Fixes
Description
This PR implements a scroll-to-top element, which fixes the accessibility issue of going back to the top on a long page.
Technical details
vocabulary.css
filearchive-page.html
file in thecontext
folderTests
archive-page.html
file on your preferred browser and scrollScreenshots
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin