Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile alignment blue boxes #236

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vickova
Copy link
Contributor

@vickova vickova commented Oct 16, 2024

Fixes

Description

This PR addresses the improper alignment of blue boxes in the mobile view on program-index.html. The alignment issue was causing a visual inconsistency on smaller screens. Changes have been made to the CSS (vocabulary.css) file to ensure proper alignment of these boxes across different mobile screen sizes.

Technical details

  • Updated the CSS (vocabulary.css) styles in line 1776 to adjust the layout of the blue boxes for mobile devices.
  • Added media queries to handle the alignment for different screen widths.
  • Ensured that the boxes are evenly spaced and aligned for a consistent user experience.

Tests

  • Open program-index.html on a mobile device or use a mobile view in the browser's developer tools.
  • Verify that the blue boxes are properly aligned across various screen sizes.
  • Check the responsiveness by resizing the screen to ensure the boxes remain consistently aligned.

Screenshots

Screenshot (311)

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@vickova vickova requested review from a team as code owners October 16, 2024 02:25
@vickova vickova requested review from TimidRobot, possumbilities, MuluhGodson and hugosolar and removed request for a team October 16, 2024 02:25
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for vocabulary-docs ready!

Name Link
🔨 Latest commit 5c95af0
🔍 Latest deploy log https://app.netlify.com/sites/vocabulary-docs/deploys/670f243146cd4d0008b92816
😎 Deploy Preview https://deploy-preview-236--vocabulary-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Raja-Abrar-Khan
Copy link
Contributor

Hey @vickova as you can see the issue status is still awaiting ,you can contribute to the issues that are ready for work. You can read this https://github.com/SisiVero/CC-guides/blob/main/README.md hope it helps. Have a Good day.

@vickova vickova closed this Oct 16, 2024
@vickova vickova deleted the mobile-alignment-blue-boxes branch October 16, 2024 08:34
@vickova vickova restored the mobile-alignment-blue-boxes branch October 29, 2024 19:24
@vickova vickova reopened this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug] Improper Alignment of Blue Boxes in Mobile View in program-index.html
3 participants