Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Mobile responsiveness issues in search-index.html #150

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

egbadon-victor
Copy link
Contributor

Fixes

Description

This PR resolves all the mobile responsiveness issues on the search-index.html page. Making it responsive all the way to the standard 320px screen width.

Technical details

This was implemented using the already existing design guidelines and implementation
-By adjusting the grid-column property, based on the screen width
-Applying the var(--vocabulary-page-edges-space) value as margin for smaller screen sizes, so the content is not directly against the screen bezels
-Reseting styles that break the content arrangement on smaller screens.

This approach also put into consideration other context pages, making changes that would contribute towards resolving mobile responsiveness issues on other context pages.

Tests

  • Fork and the clone the creativecommons/vocabulary project unto your local machine.
  • Launch the search-index.html file on your browser
  • Toggle the developer console by hitting Ctrl + shift + I and then toggling the option for device toolbar.
  • Test the UI at all screen sizes for mobile responsiveness by visual inspection of each element. Particularly screen sizes lesser than 680px
  • Test the UI on various browsers for compatibility.

image
image
image
image
image
image
image
image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@egbadon-victor egbadon-victor requested review from a team as code owners October 8, 2024 17:52
@egbadon-victor egbadon-victor requested review from TimidRobot, Shafiya-Heena, possumbilities, MuluhGodson and kgodey and removed request for a team October 8, 2024 17:52
Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for vocabulary-docs ready!

Name Link
🔨 Latest commit 44b8294
🔍 Latest deploy log https://app.netlify.com/sites/vocabulary-docs/deploys/6716ba175bb4f20008e7e808
😎 Deploy Preview https://deploy-preview-150--vocabulary-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@egbadon-victor
Copy link
Contributor Author

Hello @possumbilities

Going over the list of issues in the repo, I see a lot of responsiveness issues. By inspection, a lot of them are related and can be resolved by similar style changes. Hence, could this PR for a foundation for the resolution of all the mobile responsiveness issues for all the contexts in the vocabulary docs. Is this a good idea, or that would just be too many changes for one PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Bug] Mobile Responsiveness Issue on search-index.html Page
1 participant