Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #112 using a DSA key results in an rPM package with an unverifi… #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bschelberg
Copy link

Using a DSA key results in an RPM package with an unverifiable signature

It seems like DSA has been deprecated by some projects, and we're strongly
encouraged to move to RSA. However, Redline RPM currently accepts DSA
keys for sigining, but signs the package incorrectly, resulting in
errors from RPM with errors that are difficult to diagnose.

…an unverifiable signature

IT seems like DSA has been deprecated by some projects, and we're strongly
encouraged to move to RSA. However, Redline RPM currently accepts DSA
keys for sigining, but signs the package incorrectly, resulting in
errors from RPM with errors that are difficult to diagnose.
@kkolinko
Copy link

I do not like this.

  1. It breaks the feature implemented by Make RPM task not fail when the signature cannot be read #77
    In scenario of Make RPM task not fail when the signature cannot be read #77 your getAlgorithm() call will return null and you will fail with IAE.
    Expected behaviour is to fall through and set this.enabled=false,

  2. It does not solve the issue of wrong signature by generating a correct one. It just disallows one to generate any other signature besides RSA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants