Adds bypass to SSL verification through option in config #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting. While I prefer the more compact formatting, I decided to standardize on the same formatting that HASS uses. For pyscript I set these up to automatically run when you push, but for this repository it's still manual. Here are the formatting / checking commands I run: Can you run these and confirm the formatting is now unchanged? If so, please update the PR. |
|
Sure. Thanks for that guidance. If I don't get to it today will do it
tomorrow morning.
All the best,
Andreas.
…On Mon, Jul 25, 2022 at 8:57 PM Craig Barratt ***@***.***> wrote:
Thanks for submitting. While I prefer the more compact formatting, I
decided to standardize on the same formatting that HASS uses. For pyscript
I set these up to automatically run when you push, but for this repository
it's still manual.
Here are the formatting / checking commands I run:
isort hass_pyscript_kernel/*py
black hass_pyscript_kernel
flake8 hass_pyscript_kernel/*py
pylint hass_pyscript_kernel/*py
Can you run these and confirm the formatting is now unchanged? If so,
please update the PR.
—
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTBX2TOUP62YG5GMX2MERTVV3PQNANCNFSM54TARA7A>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@craigbarratt commit with format changes done. Let me know if all good. |
|
Looks good - thanks for submitting the PR. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with this issue.
Sorry for the formatting changes - they weren't intentional. Hope that's ok.