-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6633] Remove all logical resources from code #3869
base: develop
Are you sure you want to change the base?
Conversation
…o enhancement/6633 # Conflicts: # ui/app/src/components/PreviewPageExplorerPanel/PreviewPageExplorerPanel.tsx
…o enhancement/6633 # Conflicts: # ui/app/src/CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the useLogicResource and associated code too. Add to changelog
@rart added back PreviewInPageInstancesPanel as it is being used by the PreviewComponentsPanel |
@jvega190 bump. this has pending changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- There's a
ComponentResource
Interface on PreviewBrowseComponentsPanelUI which is not in use. Try to find other resource-related things like this that might have also slipped by.
ui/app/src/components/ChangeContentTypeDialog/ChangeContentTypeDialogContainer.tsx
Outdated
Show resolved
Hide resolved
ui/app/src/components/ChangeContentTypeDialog/ChangeContentTypeDialogContainer.tsx
Outdated
Show resolved
Hide resolved
ui/app/src/components/ChangeContentTypeDialog/ChangeContentTypeDialogContainer.tsx
Outdated
Show resolved
Hide resolved
ui/app/src/components/CompareVersionsDialog/CompareVersionsDialogContainer.tsx
Outdated
Show resolved
Hide resolved
ui/app/src/components/DeleteContentTypeDialog/DeleteContentTypeDialogContainer.tsx
Outdated
Show resolved
Hide resolved
ui/app/src/components/NewContentDialog/NewContentDialogContainer.tsx
Outdated
Show resolved
Hide resolved
ui/app/src/components/NewContentDialog/NewContentDialogContainer.tsx
Outdated
Show resolved
Hide resolved
ui/app/src/components/PreviewInPageInstancesPanel/PreviewInPageInstancesPanel.tsx
Outdated
Show resolved
Hide resolved
…o enhancement/6633 # Conflicts: # ui/app/src/CHANGELOG.md # ui/app/src/components/PreviewDropTargetsPanel/PreviewDropTargetsPanel.tsx
c6d235c
to
d9d8971
Compare
Should I get rid of this signature too? https://github.com/craftercms/studio-ui/blob/develop/ui/app/src/components/StoreProvider/StoreProvider.tsx#L26 |
Yes. Why wouldn't we? |
Pls fix conflicts. |
…o enhancement/6633 # Conflicts: # ui/app/src/CHANGELOG.md
@rart there were still a couple of resource-related things I removed, I'll re-request review |
…o enhancement/6633 # Conflicts: # ui/app/src/components/CompareVersionsDialog/CompareVersionsDialogContainer.tsx # ui/app/src/components/PreviewDropTargetsPanel/PreviewDropTargetsPanel.tsx # ui/app/src/components/SiteManagement/SiteManagement.tsx # ui/app/src/components/ToolsPanel/ToolsPanel.tsx
craftercms/craftercms#6633