Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LineContainer.mdx #4518

Closed
wants to merge 76 commits into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Jun 12, 2024

From USACO Guide Module Bounties

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.

  • I have tested my code.
  • I have added my solution according to the steps here.
  • I have followed the code conventions mentioned here.
    • I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
    • If changes are requested, I will re-request a review after addressing them.
  • I have linked this PR to any issues that it closes.

From USACO Guide Module Bounties
@ghost ghost requested a review from dongliu0426 as a code owner June 12, 2024 11:05
Copy link
Contributor

@SansPapyrus683 SansPapyrus683 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally, another one on this site that knows how to use classes

content/6_Advanced/LineContainer.mdx Outdated Show resolved Hide resolved
content/6_Advanced/LineContainer.mdx Outdated Show resolved Hide resolved
content/6_Advanced/LineContainer.mdx Show resolved Hide resolved
content/6_Advanced/LineContainer.mdx Show resolved Hide resolved
content/6_Advanced/LineContainer.mdx Outdated Show resolved Hide resolved
content/6_Advanced/LineContainer.mdx Show resolved Hide resolved
content/6_Advanced/LineContainer.mdx Outdated Show resolved Hide resolved
@SansPapyrus683
Copy link
Contributor

image

also uh 💀
you probably shoulda contacted us to claim the bounty first

@ghost ghost requested a review from SansPapyrus683 June 12, 2024 16:38
@ghost
Copy link
Author

ghost commented Jun 12, 2024

merge the pull request now???

@SansPapyrus683
Copy link
Contributor

calm down man i haven't reviewed the other parts
also you need two approvals

@SansPapyrus683
Copy link
Contributor

https://docs.google.com/document/d/1Dzj5uYNYNXe_E-_9-lSeX73654cGJk88PZ0kZCCmks0/edit

so we've just recently come up with this new module layout standard, if you could adjust your module to fit this that'd be great

I removed the header since there's just one focus problem, and I also have the explanation and implementation sections, as detailed in the document. If you have any more suggestions, please specify them (bcz I think the module looks good now).
Copy link
Member

@ryanchou-dev ryanchou-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you save your diagrams in the root folder? Move your images to the section folder and import via relative paths.

content/6_Advanced/LineContainer.mdx Outdated Show resolved Hide resolved
added images properly in the assets folder of advanced
@ghost
Copy link
Author

ghost commented Jul 12, 2024

i moved all the images to the correct place and added them via relative paths

@ghost ghost closed this Jul 16, 2024
@ghost ghost deleted the patch-2 branch July 16, 2024 16:53
@ghost ghost restored the patch-2 branch July 16, 2024 17:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants