-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LineContainer.mdx #4518
Update LineContainer.mdx #4518
Conversation
From USACO Guide Module Bounties
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finally, another one on this site that knows how to use classes
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
merge the pull request now??? |
calm down man i haven't reviewed the other parts |
https://docs.google.com/document/d/1Dzj5uYNYNXe_E-_9-lSeX73654cGJk88PZ0kZCCmks0/edit so we've just recently come up with this new module layout standard, if you could adjust your module to fit this that'd be great |
I removed the header since there's just one focus problem, and I also have the explanation and implementation sections, as detailed in the document. If you have any more suggestions, please specify them (bcz I think the module looks good now).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you save your diagrams in the root folder? Move your images to the section folder and import via relative paths.
Co-authored-by: Ryan Chou <[email protected]>
added images properly in the assets folder of advanced
Delete extra image copies
i moved all the images to the correct place and added them via relative paths |
From USACO Guide Module Bounties
Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.