Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation errors #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix compilation errors #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions classify_fake_DS18B20.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,8 +308,8 @@ void loop() {
int identified = 0;

{ // test for family E, added 19 March 2024
uint8_t sp21, sp22;
uint8_t sp21b, sp22b;
uint32_t sp21, sp22;
uint32_t sp21b, sp22b;
ds->reset();
ds->select(addr);
ds->write(0xDE);
Expand Down
5 changes: 2 additions & 3 deletions discover_fake_DS18B20.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ void setup() {

{
// output file name without leading path
char *file = __FILE__;
auto *file = __FILE__;
int i;
for (i = strlen(file); i > 0; i--)
if ((file[i] == '\\') || (file[i] == '/')) {
Expand Down Expand Up @@ -273,8 +273,7 @@ void loop() {

Comm.print(" Checking byte 6 upon temperature change: ");
if (( ((buffer2[0] == 0x50) && (buffer2[1] == 0x05)) || ((buffer2[0] == 0xff) && (buffer2[1] == 0x07)) ||
((buffer2[6] == 0x0c) && (((buffer2[0] + buffer2[6]) & 0x0f) == 0x00)) ) &&
((buffer2[6] >= 0x00) && (buffer2[6] <= 0x10)) ){
((buffer2[6] == 0x0c) && (((buffer2[0] + buffer2[6]) & 0x0f) == 0x00)) ) && (buffer2[6] <= 0x10) ){
// byte 6 checked out as correct in the initial test but the test ambiguous.
// we need to check if byte 6 is consistent after temperature conversion

Expand Down