[Enhancement] Handle balance errors gracefully #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR(Pull Request) Overview
A small enhancement to handle empty balance responses in a graceful manner. This prevents errors in case the balance of an address is 0. This can happen if a validator address does not hold any tokens itself. In such a case it is assumed the balance of the address is 0
Changes
Description of Changes
To catch the exception/error a new error type
ErrBalanceNotFoundis created. This error will be used if theStringBalanceis empty. The higher level code will catch this specific error assume the balance as
0and raise a warning instead.Testing Method
I added a unit test to test the behavior is as expected